score:110

Accepted answer

Constructor is not a right place to make API calls.

You need to use lifecycle events:

Make sure to compare the props with the previous props in componentDidUpdate to avoid fetching if the specific prop you care about hasn't changed.

class TranslationDetail extends Component {    
   componentDidMount() {
     this.fetchTrans();
   }

   componentDidUpdate(prevProps) {
     if (prevProps.params.id !== this.props.params.id) {
       this.fetchTrans();
     }
   }

   fetchTrans() {
     this.props.fetchTrans(this.props.params.id);
   }
}

score:-1

I would use the render method. If the data is not loaded I would render a loader spinner and throw the action that fetch de data. For that i usually use the stores. Once the store has de data from the api, mark the data as loaded, throw an event and let the component get the data from the store, replacing the loader spinner with your data representation.

score:0

Use componentWillMount to get the data and set the state. Then use componentWillReceiveProps for capturing update on the props.

You can check the Component Specs and Lifecycle.

score:7

From React 16.3 and onwards componentWillMount, componentWillUpdate and componentWillReceiveProps are deprecated.

You can use static getDerivedStateFromProps and return a new state based on changes on props.

You don't have access to your this objects like props, so you cannot compare nextProps with your current props by nextProps.sth !== this.props.sth. You can compare you prevState value with nextProps and return new value of state.

Make sue you add UNSAFE_ to your current componentWillMount and the other deprecated lifecyle methods for now.


Related Query

More Query from same tag